Remove ActivateProfileColour (it was rarely used or even known, and blocked work on the profiling engine)
#5301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
the
release notes: use title
fingolfin
changed the title
ActivateProfileColour (it was rarely used or even known, and blocked work on the profiling engine)
fingolfin
reviewed
Jan 2, 2023
| return Fail; | ||
| } | ||
|
|
||
| ActivatePrintHooks(&profilePrintHooks); |
Member
There was a problem hiding this comment.
Is it worth it to keep the whole print hook machinery in place?
fingolfin
reviewed
Jan 2, 2023
| ** see this when we use ActivateProfileColour. However, without some | ||
| ** serious additional overheads, I can't see how to provide this | ||
| ** 3) Operating at just a line basis can sometimes be too course. However, | ||
| ** without some serious additional overheads, I can't see how to provide this |
Member
There was a problem hiding this comment.
There is another reference to colo(u)r in line 66. Also, the variable ColouringOutput is not actually removed.
I am going to update this PR to fix this and my other remarks.
fingolfin
force-pushed
the
remove_profcolour
branch
2 times, most recently
from
c3ade9b to
e173e3a
Compare
fingolfin
force-pushed
the
remove_profcolour
branch
from
e173e3a to
7daffc1
Compare
fingolfin
approved these changes
Jan 4, 2023
fingolfin
added
the
kind: removal or deprecation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5261 , which removes a function which was previously tested in the
profilingpackage.