kernel: split CLI argument parsing into two phases; and more #6015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Besides running `clang-format` on the code, we replace one IS_PLIST check by a direct tnum comparison, split 2 and 3 argument variant implementation.
Most arguments are handled in the first stage. In particular all that are relevant for the GC. The second stage is only for the arguments which add GAP roots paths: those involve storing strings, which can be of arbitrary size. We'd like to switch their handling from C strings to GAP strings, but that requires the memory manager to be initialized. With this patch, it *is* initialized before we parse the root paths.
fingolfin
added
topic: kernel
release notes: not needed
The main motivation here is to avoid calling `SySetGapRootPath` in `main` -- instead we want to defer this until just before we parse the command line arguments specifying root paths. This will in the future allow us to switch `SySetGapRootPath` to using GAP objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[This is identical to PR #6013 but I accidentally made that from a branch in this repo and then not all CI tests run, which is bad. Something to consider fixing at some point but for now...]
I've extracted parts of PR #5941 (which got stalled due to unexpected difficulties) into this PR. The idea being that that other PR gets simpler (hence easier to understand/debug/discuss), and thus there is also less chance for conflicts arising.