Skip to content

Conversation

@frieschneider
Copy link
Contributor

@frieschneider frieschneider commented Mar 20, 2025

  • adcc/PR#169 is merged: the operator integrals are dependent on the gauge origin.
  • adcc/PR#190 is merged: negative charges included in operator integrals definition.

Changes

ToDo

  • adapt ci_env.yml as soon as new adcc version is available

@frieschneider frieschneider marked this pull request as ready for review March 31, 2025 07:18


def sos_mcd_bterm(state, final_state=0):
# Note: there exists only reference data for the gauge origin placed at the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this function can also be called with a normal ExcitedStates object and not only with a MockExcitedStates object, right? I think for the former the gauge selection should still be possible and also the magnetic properties need to be adapted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this function was for testing purposes only.
See lines 110 and 111: An ExcitedStates object does not have these properties, nor does a State2States object. Thus, the function is only meant for the MockExcitedStates object.

110 s2s_tdm = state.transition_dipole_moment_s2s
111 s2s_tdm_mag = state.transition_magnetic_moment_s2s

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this used to work before the State2States class was introduced. But okay, for now, it is okay then, I guess. But maybe we could think about changing this in the future.

@frieschneider frieschneider merged commit 5555908 into gator-program:main Apr 1, 2025
2 checks passed
@frieschneider frieschneider deleted the gauge_origin_dependence branch April 1, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants