-
Notifications
You must be signed in to change notification settings - Fork 2
Add Panora swap provider for Aptos support #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Introduces PanoraProvider to enable Aptos chain swaps via Panora, including integration tests, model definitions, and API registration. Updates dependencies and referrer addresses to support Panora, and adds Panora to the SwapProvider enum.
Changed Files
|
Summary of ChangesHello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the platform's swapping capabilities by integrating Panora as a new swap provider, specifically targeting the Aptos blockchain. This integration allows users to perform Aptos-based asset exchanges, leveraging Panora's infrastructure. The changes encompass adding new provider logic, defining necessary data models for quotes and transactions, updating core dependencies, and registering the new provider within the application's API and internal enumerations. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for Panora as a swap provider on the Aptos chain. The changes are well-structured, including the new provider implementation, data models, and integration tests. My review focuses on improving type safety and data validation, particularly in the type coercion logic, which is currently too lenient and could lead to runtime errors. I've also suggested a minor refactoring in the tests to reduce code duplication and improve maintainability.
Moved formatting and argument normalization functions from provider.ts into new format.ts and move.ts modules for better code organization and reusability. Updated imports in provider.ts to use the new modules.
Added isPanoraQuoteResponse for stricter quote response validation and updated PanoraProvider to use it. Enhanced error handling in move.ts coercion functions. Refactored provider tests to reuse a single provider instance for improved efficiency.
Introduces PanoraProvider to enable Aptos chain swaps via Panora, including integration tests, model definitions, and API registration. Updates dependencies and referrer addresses to support Panora, and adds Panora to the SwapProvider enum.