Pass GIT_COMMIT to Docker

[0xh3rman]

No description provided.

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
.github/workflows/docker.yml	0% smaller
.github/workflows/publish-containers.yml	0% smaller
Dockerfile	Unsupported file format
scripts/generate-version.js	0% smaller

[gemini-code-assist]

Summary of Changes

Hello @0xh3rman, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the application's versioning strategy, specifically for Dockerized builds. It introduces a mechanism to explicitly inject the Git commit SHA into the Docker image as an environment variable. Concurrently, the version generation script has been updated to leverage this environment variable, ensuring consistent and reliable embedding of commit information into the application, thereby enhancing traceability and build process independence from local Git repositories.

Highlights

• Dockerfile Update: The Dockerfile has been updated to accept GIT_COMMIT as a build argument, which is then set as an environment variable within the Docker image. This allows for explicit passing of the Git commit SHA during the Docker build process.
• Version Script Enhancement: The scripts/generate-version.js file now prioritizes using the GIT_COMMIT environment variable (if available and not 'unknown') to determine the Git commit SHA. This provides a more robust way to embed version information, especially in containerized environments, by reducing reliance on git commands within the build.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files

• Ignored by pattern: .github/workflows/** (2)
  • .github/workflows/docker.yml
  • .github/workflows/publish-containers.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a mechanism to pass the Git commit SHA to the Docker build process via a build argument. This is then used to generate a version.json file with the correct commit hash, which is useful for builds in environments without access to the .git directory. The changes in the Dockerfile and scripts/generate-version.js are logical and achieve this goal. I have one suggestion to improve the robustness of the script by trimming whitespace from the environment variable.