Return Mayan min amount

[0xh3rman]

No description provided.

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
packages/swapper/src/mayan/error.ts	16% smaller
apps/api/src/index.test.ts	14% smaller
apps/api/src/index.ts	14% smaller
apps/api/src/error.ts	0% smaller
packages/swapper/src/error.ts	0% smaller
packages/swapper/src/index.ts	0% smaller
packages/swapper/src/mayan/index.test.ts	0% smaller
packages/swapper/src/mayan/index.ts	0% smaller
packages/swapper/src/mayan/provider.ts	0% smaller

[gemini-code-assist]

Summary of Changes

Hello @0xh3rman, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors and standardizes error handling across the swapper API, with a particular focus on the Mayan provider. By introducing a custom SwapperException and centralizing error response logic, the changes ensure that API consumers receive consistent, structured, and informative error messages, including specific details like minimum amounts for input errors. This improves the robustness and usability of the API's error reporting.

Highlights

• Standardized Error Handling: Introduced a new SwapperException class to wrap SwapperError types, providing a consistent way to propagate structured errors throughout the application.
• Centralized API Error Responses: Created a dedicated error.ts module in the API to centralize error response formatting (errorResponse) and HTTP status code mapping (httpStatus), ensuring uniform error messages and status codes for API consumers.
• Enhanced Mayan Minimum Amount Parsing: Improved the Mayan provider's error handling to accurately parse 'Amount too small' messages, extracting the minimum required amount and converting it into a structured input_amount_error with the correct decimal precision.
• API Endpoint Integration: Refactored API endpoints (/quote and /quote_data) to utilize the new SwapperException and centralized error handling utilities, providing more informative and structured error responses.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a more robust and structured error handling mechanism, particularly for the Mayan provider. It adds a custom SwapperException to wrap specific swap errors, refactors API error responses into a dedicated module, and improves the Mayan provider to parse and return specific 'amount too small' errors. The changes are well-implemented and include corresponding tests. My review includes suggestions to further improve robustness by handling default cases in switch statements, reducing code duplication in API endpoints, and making a regular expression more specific to prevent potential parsing issues.