-
Notifications
You must be signed in to change notification settings - Fork 41
Add wallet context to auth guard and store nonce in sessions #915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
5
commits into
main
Choose a base branch
from
copilot/add-devices-sessions-table
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+112
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Files
|
Co-authored-by: gemcoder21 <104884878+gemcoder21@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add devices_sessions table for login signatures and device IDs
Add devices_sessions table for authentication audit trail
Jan 28, 2026
Aarcsupplier
approved these changes
Jan 28, 2026
Co-authored-by: gemcoder21 <104884878+gemcoder21@users.noreply.github.com>
Copilot
AI
changed the title
Add devices_sessions table for authentication audit trail
Use wallet_id FK in devices_sessions instead of address string
Jan 28, 2026
Co-authored-by: gemcoder21 <104884878+gemcoder21@users.noreply.github.com>
Co-authored-by: gemcoder21 <104884878+gemcoder21@users.noreply.github.com>
Copilot
AI
changed the title
Use wallet_id FK in devices_sessions instead of address string
Add wallet context to auth guard and store nonce in sessions
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auth guard now provides wallet context to authenticated endpoints, eliminating redundant wallet lookups. Device sessions now capture the full authentication tuple (device, wallet, nonce, signature) for complete audit trails.
Changes
Enhanced VerifiedAuth
Added nonce to devices_sessions
nonce VARCHAR(256) NOT NULLEliminated redundant operations
WalletId::Multicoin(address).id()and re-fetched walletauth.wallet_idandauth.wallet_identifierdirectlyCode organization
primitives::WalletTypeandprimitives::WalletSourceto top-level importsprimitives::qualifiers throughoutExample
Before:
After:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.