-
Notifications
You must be signed in to change notification settings - Fork 56
Add Yielder #1608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Yielder #1608
Conversation
Introduces the Yield module, including Swift Package setup, scene, view models, and UI components for displaying yield opportunities and positions. Integrates Yield into Assets and Staking features, updates navigation, and extends transfer and primitives types to support yield actions. Adds new resources and images for yield providers, and updates dependencies and project configuration accordingly.
Deleted the unused 'name' property from GemYieldProvider and removed debug print statements from YieldSceneViewModel's fetch method for cleaner code. Updated core submodule reference.
Summary of ChangesHello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a comprehensive 'Yield' feature, enabling users to engage with yield-generating protocols directly within the application. It establishes a new dedicated module for yield management, integrates yield information into existing asset and staking views, and extends the transaction processing system to support yield deposits and withdrawals. The changes ensure a cohesive user experience for discovering and participating in yield opportunities. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
- Resolve conflicts with yield feature integration
d8c1d1b to
6b1249f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant new "Yield" feature, allowing users to earn on their assets. The changes are extensive, touching multiple features to integrate this functionality, including UI additions in the Assets and Staking scenes, and core logic modifications in Transfer, Signer, and the newly created Yield and YieldService packages. My review focuses on ensuring the correctness and precision of balance calculations by advocating for the use of BigInt over Double, and on improving error handling for better debuggability. Overall, the implementation is well-structured and consistent with the existing architecture.
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Resolved conflicts to keep both YieldService (yielder branch) and Support/ConnectionsService (main branch) features, using appLifecycleService (renamed from observersService).
Uh oh!
There was an error while loading. Please reload this page.