Skip to content

Conversation

@Abeansits
Copy link
Contributor

@Abeansits Abeansits commented Apr 3, 2025

As requested in CONTRIBUTING.md I've added some missing doc strings.
Can't confirm they are 100% correct since I don't have an invite yet. ;)

Doc strings added to:

  • agent.py
  • action.py
  • computer.py

- agent.py
- action.py
- computer.py
@psarka
Copy link
Collaborator

psarka commented Apr 4, 2025

Sweet, thank you! ❤️

I left some comments if you don't mind :)

@Abeansits
Copy link
Contributor Author

@psarka thanks for the feedback, got them resolved

@psarka
Copy link
Collaborator

psarka commented Apr 10, 2025

Awesome! Can you run uv run pre-commit run --all-files, ruff format is complaining :)

@Abeansits
Copy link
Contributor Author

you got it @psarka

would be nice with some CI checks here at some point :)

@psarka
Copy link
Collaborator

psarka commented Apr 10, 2025

There is a CI check, but I need to approve for it to run. I think it's because it's your first contribution:

https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/approving-workflow-runs-from-public-forks

By default, all first-time contributors require approval to run workflows.

Anyways, everything is green now 🥳

@psarka psarka self-requested a review April 10, 2025 20:48
@psarka psarka merged commit df4293a into generalagents:main Apr 10, 2025
5 checks passed
@Abeansits Abeansits deleted the docs-added branch April 12, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants