-
-
Notifications
You must be signed in to change notification settings - Fork 308
fix support for custom formatters (#1997) #2144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dbbce65 to
b364419
Compare
051ccbb to
4ae51b6
Compare
webb-ben
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I will test later today. Some small questions / comments.
-
This implements custom formatters for OAFeat and OARec GeoJSON responses. Can we add some additional documentation to clarify this? Is support for EDR CovJSON Formatters an entirely different issue? I have a simple Point-based CovJSON -> CSV formatter that I would like to synchronize these changes with.
-
After this is merged I will migrate our OGR Formatter to https://github.com/cgs-earth/pygeoapi-plugins. I will want to figure out how much of this can be offloaded to the configuration options introduced. Depending on the path this takes, a general OGR formatter could subsume #2136 and our custom formatter.
| super().__init__({'name': 'cooljson', 'geom': None}) | ||
| self.mimetype = 'application/json; subtype:mycooljson' | ||
| self.f = 'cooljson' # f= value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the formatter need to response both f= and the Accept Header?
0790903 to
f5f89f4
Compare
bc3d32e to
6085edc
Compare
Overview
This PR updates formatters support to allow for custom formatters for item types and EDR.
Related Issue / discussion
#1997
Additional information
Dependency policy (RFC2)
Updates to public demo
Contributions and licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)