-
-
Notifications
You must be signed in to change notification settings - Fork 308
Fix WMTSFacade provider #2167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix WMTSFacade provider #2167
Conversation
'style' query parameter is mandatory according to WMTS 1.0.0 standard. For backwards compatibility, empty string remains as default value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dolite Thank You for this enhancement to the provider, by exposing the style parameter, which currently is set to ' ' . When this parameter is empty, the server always fallbacks to the default style; In my comment I suggest you update the description on the documentation to make this behaviour more clear.
Please note that this is not a bug, as the provider does not necessarily need to expose all the mandatory parameters of WMTS; I think keeping it optional, as you did, is a good idea; to support backwards compatibility and also to make configuration easier for the users.
Clarified wmts_style description in ogcapi-tiles.rst.
doublebyte1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge
|
Vulnerability check seems to be unrelated |
|
Hi ! Sorry I just see your comments. I had totally forgotten this PR. When I tried your server, requests to source WMTS server were sent without STYLE query parameter and an error occured. That's why I added the style configuration. Thanks for fixing my documentation and for merging the PR. Have a nice day and a nice year ! |
'style' query parameter is mandatory according to WMTS 1.0.0 standard. For backwards compatibility, empty string remains as default value.
Overview
Related Issue / discussion
Additional information
Dependency policy (RFC2)
Updates to public demo
Contributions and licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)