Skip to content

Conversation

@Dolite
Copy link
Contributor

@Dolite Dolite commented Nov 24, 2025

'style' query parameter is mandatory according to WMTS 1.0.0 standard. For backwards compatibility, empty string remains as default value.

Overview

Related Issue / discussion

Additional information

Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute bugfix to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

'style' query parameter is mandatory according to WMTS 1.0.0 standard. For
backwards compatibility, empty string remains as default value.
@doublebyte1 doublebyte1 added the enhancement New feature or request label Dec 2, 2025
Copy link
Contributor

@doublebyte1 doublebyte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dolite Thank You for this enhancement to the provider, by exposing the style parameter, which currently is set to ' ' . When this parameter is empty, the server always fallbacks to the default style; In my comment I suggest you update the description on the documentation to make this behaviour more clear.

Please note that this is not a bug, as the provider does not necessarily need to expose all the mandatory parameters of WMTS; I think keeping it optional, as you did, is a good idea; to support backwards compatibility and also to make configuration easier for the users.

Clarified wmts_style description in ogcapi-tiles.rst.
@doublebyte1 doublebyte1 self-requested a review December 9, 2025 19:20
Copy link
Contributor

@doublebyte1 doublebyte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge

@doublebyte1
Copy link
Contributor

Vulnerability check seems to be unrelated

@doublebyte1 doublebyte1 merged commit b8237be into geopython:master Dec 9, 2025
3 of 4 checks passed
@tomkralidis tomkralidis added the OGC API - Tiles OGC API - Tiles label Dec 9, 2025
@tomkralidis tomkralidis added this to the 0.23.0 milestone Dec 9, 2025
@Dolite
Copy link
Contributor Author

Dolite commented Jan 12, 2026

Hi !

Sorry I just see your comments. I had totally forgotten this PR. When I tried your server, requests to source WMTS server were sent without STYLE query parameter and an error occured. That's why I added the style configuration. Thanks for fixing my documentation and for merging the PR.

Have a nice day and a nice year !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request OGC API - Tiles OGC API - Tiles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants