Skip to content

Conversation

@randomComitter
Copy link

It's sad that this nice library has a bit outdated structure and styling.
I restructured the files and refactored the code to better comply to psr-2 coding style guide.
Tests and readme were also modified.

@qyanu
Copy link

qyanu commented Jun 29, 2016

@WallTearer since some of your propsed changes are already included (by some other means): what do you think remains of your cleanup proposals?

@randomComitter
Copy link
Author

@qyanu, sorry, I completely missed your question.
I guess this lib looks way nicer now than before, cause it has a better file structure, namespaces, no global constants, so my pull request doesn't bring anything really special. You can discard/close it if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants