wip: Stuck detector #442
Closed
wip: Stuck detector #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpacifici
reviewed
Apr 7, 2025
Contributor
fpacifici
left a comment
fpacifici
left a comment
There was a problem hiding this comment.
Do you have context about this? Is there a specific scenario where the consumer got stuck?
Member
Author
|
@fpacifici I opened this PR because I was chatting with Riya about #439, but I think I misunderstood the situation there. The consumer gets stuck in paused state, not stuck in a way that it exceeds max-poll-intervall. We've had a few situations where the main thread got stuck, but none recently |
untitaker
added a commit
that referenced
this pull request
Dec 2, 2025
Implement a background thread that dumps all stacktraces when the main thread gets stuck. variations of this are: * getsentry/sentry#100857 -- unlike that PR, this one can run enabled in all consumers, since it only reports stacktraces when we're actually stuck. * #442 -- this is a previous version that only reported on the main thread, and in an overly complicated manner. We cannot use faulthandler because that one can only report to "real" files, and I want to report the stuck consumers to logging/Sentry.
Merged
untitaker
added a commit
that referenced
this pull request
Dec 2, 2025
* ref: Stuck detector Implement a background thread that dumps all stacktraces when the main thread gets stuck. variations of this are: * getsentry/sentry#100857 -- unlike that PR, this one can run enabled in all consumers, since it only reports stacktraces when we're actually stuck. * #442 -- this is a previous version that only reported on the main thread, and in an overly complicated manner. We cannot use faulthandler because that one can only report to "real" files, and I want to report the stuck consumers to logging/Sentry. * shut down thread to prevent leaks in tests * shutdown properly again in tests * make it timestamp based, make test faster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.