Fix(android): Preserve protobuf attributes for accurate resource lookup #537
+16
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes LAUNCHPAD-6D. The issue was that: ProtoXmlUtils expects protobuf XmlAttribute objects, but receives dataclass XmlAttribute objects lacking the 'compiled_item' field.
_attrs_to_pb_attrs) to store original protobuf attributes associated with their converted attribute lists._get_attr_valueto retrieve and use the original protobuf attributes when performing resource lookups viaProtoXmlUtils.ProtoXmlUtilsfunctions receive the full protobuf attribute context, preventing potential issues with compiled items or resource resolution.This fix was generated by Seer in Sentry, triggered by Hector Dearman. 👁️ Run ID: 8532303
Not quite right? Click here to continue debugging with Seer.