Skip to content

Add extra check for cms signature before parsing #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NicoHinderling merged 1 commit into from
Jan 14, 2026
Merged

Add extra check for cms signature before parsing #539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/launchpad/parsers/apple/code_signature_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,11 +581,20 @@ def _parse_signature(self, super_blob: CSSuperBlob, cs: CodeSignature) -> CMSSig

logger.debug(f"Signature magic: 0x{magic:08x}, length: {signature_length}")

# Check if there's actual signature data (not just the header)
if signature_length <= 8:
logger.debug("Signature slot present but empty (length <= 8)")
return None

# Extract the signature content (skip the 8-byte header)
sig_start = sig_offset + 8
sig_end = sig_offset + signature_length
signature_content = bytes(content[sig_start:sig_end])

if len(signature_content) == 0:
logger.debug("No signature content to parse")
return None

# Parse the CMS signature
try:
signature = cms.ContentInfo.load(signature_content) # type: ignore[attr-defined]
Expand Down
Loading