Skip to content

Fix handled error when icon couldn't be parsed #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rbro112 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix handled error when icon couldn't be parsed #541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/launchpad/artifacts/android/manifest/proto_xml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,11 +356,11 @@ def _get_optional_attr_value(
if not value:
logger.debug("could not find string value for attribute matching filter, trying to parse compiled value")

if not attribute.compiled_item:
compiled_item = getattr(attribute, "compiled_item", None)
if not compiled_item:
logger.debug("could not find compiledItem for attribute matching filter")
return None

compiled_item = attribute.compiled_item
if compiled_item.HasField("str"):
return str(compiled_item.str.value)
elif compiled_item.HasField("ref"):
Expand Down
4 changes: 2 additions & 2 deletions src/launchpad/parsers/android/icon/icon_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,8 @@ def _render_adaptive_icon(self, root_element: XmlNode) -> bytes | None:

def _render_vector_drawable(self, root_element: XmlNode) -> bytes | None:
# Extract vector attributes
width = self._get_attr_value(root_element.attributes, "width", required=True)
height = self._get_attr_value(root_element.attributes, "height", required=True)
width = self._get_attr_value(root_element.attributes, "width")
height = self._get_attr_value(root_element.attributes, "height")
viewport_width = self._get_attr_value(root_element.attributes, "viewportWidth")
viewport_height = self._get_attr_value(root_element.attributes, "viewportHeight")
tint = self._get_attr_value(root_element.attributes, "tint")
Expand Down
Loading