feat: migrate from black,isort,flake8 to ruff #7629
+2,056
−5,392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylemumma
force-pushed
the
krm/blacktoruff
branch
from
047aef7 to
95711b4
Compare
kylemumma
force-pushed
the
krm/blacktoruff
branch
from
d3fb441 to
96adace
Compare
phacops
reviewed
Jan 12, 2026
| "E302", # expected 2 blank lines, found N | ||
| "E501", # line too long (handled by formatter) | ||
| "E402", # module level import not at top of file | ||
| "E712", # comparison to True/False |
Contributor
There was a problem hiding this comment.
Why ignore those ones? Especially E266, E302 or E712? Is it to match current behavior?
Member
Author
There was a problem hiding this comment.
Yes all the ignores are to match the previous configuration. But I would support getting rid of any ignores, and re-adding if we need it in the future.
phacops
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces black(formatting), isort(import formatting), flake8 (linter) with ruff which is faster and does all 3 in one, it is the new industry standard.
This PR migrates to ruff and reformats+lints the entire codebase with it. Its a large diff but we should just be able to rollback if things break.
You can see this commit for the main changes that actually migrate to ruff 65852d3 the rest of the diff is just from running the formatter
ruff formatthere was a single linting change made to this file, but it is logically equivalent since it was duplicate keysflake8-bugbear adds additional linting on top of flake8, our previous flake8 config enabled this but we didnt have flake8-bugbear installed in our dependencies so it wasnt actually being run. For now I disable bugbear, as a follow up I will enable it for new changes.