server : implement extra_args support for /models/load endpoint #18232
+39
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
devops
Chrisischris
requested review from
CISC,
ggerganov and
ngxson
as code owners
CISC
reviewed
Dec 21, 2025
Comment on lines
-184
to
+188
| - build: 's390x' | ||
| os: ubuntu-24.04-s390x | ||
| - build: 'ppc64le' | ||
| os: ubuntu-24.04-ppc64le | ||
| # Disabled - requires special GitHub runners not available on forks | ||
| # - build: 's390x' | ||
| # os: ubuntu-24.04-s390x | ||
| # - build: 'ppc64le' | ||
| # os: ubuntu-24.04-ppc64le |
Comment on lines
-137
to
+139
| - build: 's390x' | ||
| os: ubuntu-24.04-s390x | ||
| # Disabled - requires special GitHub runners not available on forks | ||
| # - build: 's390x' | ||
| # os: ubuntu-24.04-s390x |
Author
|
Closing to recreate from a clean branch without unrelated CI changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
extra_argsfeature for/models/loadthat is already documented in the server README but was not yet implemented.From the docs:
Changes
common/common.h: Addmodels_allow_extra_argsparamcommon/arg.cpp: Add--models-allow-extra-args/--no-models-allow-extra-argsflagtools/server/server-models.h: Updateload()signature to acceptextra_argstools/server/server-models.cpp: Parseextra_argsfrom JSON body and append to child process argsSee server README for usage documentation.