please.sh create-artifact: fix the detection whether this is an i686 SDK #671
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The detection relies on the presence of a directory I thought would not ever go away: /usr/i686-pc-msys/. As of git-for-windows/git-sdk-32@76fc2e9682 (Update 88 packages, 2026-01-12), however, this is no longer true. This directory was superseded by the `/usr/i686-pc-cygwin/` directory, in an ongoing (and back-reaching to i686, apparently) effort to make MSYS2 maintenance easier by aligning it even more with Cygwin. This led to a problem in the git-artifacts workflow of the git-sdk-32 repository, as it uses the architecture aut-detection logic: https://github.com/git-for-windows/git-sdk-32/actions/runs/21019330747/job/60468238414#step:5:111 The same is not true for the _actual_ `git-artifacts` workflow in the `git-for-windows-automation` repository, which always initializes the `build-installers` artifact of the Git for Windows SDK specifying the architecture explicitly. See e.g. https://github.com/git-for-windows/git-for-windows-automation/actions/ru ns/21031008777/job/60466832552#step:11:99 Nevertheless, the auto-detection is now broken, and the auto-detection needs to be fixed, so do that. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
mjcheetham
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The detection relies on the presence of a directory I thought would not ever go away: /usr/i686-pc-msys/.
As of git-for-windows/git-sdk-32@76fc2e9682 (Update 88 packages, 2026-01-12), however, this is no longer true. This directory was superseded by the
/usr/i686-pc-cygwin/directory, in an ongoing (and back-reaching to i686, apparently) effort to make MSYS2 maintenance easier by aligning it even more with Cygwin.This led to a problem in the git-artifacts workflow of the git-sdk-32 repository, as it uses the architecture aut-detection logic: https://github.com/git-for-windows/git-sdk-32/actions/runs/21019330747/job/60468238414#step:5:111
The same is not true for the actual
git-artifactsworkflow in thegit-for-windows-automationrepository, which always initializes thebuild-installersartifact of the Git for Windows SDK specifying the architecture explicitly. See e.g.https://github.com/git-for-windows/git-for-windows-automation/actions/ru ns/21031008777/job/60466832552#step:11:99
Nevertheless, the auto-detection is now broken, and the auto-detection needs to be fixed, so do that.