mingw-w64-git-credential-manager: don't cross-polute archs #673
+14
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcheetham
commented
Jan 23, 2026
We have been downloading and extracting the pre-built binaries for Git Credential Manager to the same $srcdir directory, meaning that when we build multiple architectures we're not always starting from a clean slate and have been grabbing binaries from other architectures. Before we added support for x86_64 and clangarm64 native binaries, this was OK since we only downloaded the i686 flavour of GCM files. Update the PKGBUILD to no longer extract the GCM binaries, but manually extract them to an architecture-specific directory - this way we don't cross-contaminate. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
mjcheetham
force-pushed
the
gcm-build-fix
branch
from
eb4987b to
a5ec1c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been downloading and extracting the pre-built binaries for Git Credential Manager to the same $srcdir directory, meaning that when we build multiple architectures we're not always starting from a clean slate and have been grabbing binaries from other architectures.
Before we added support for x86_64 and clangarm64 native binaries, this was OK since we only downloaded the i686 flavour of GCM files.
Update the PKGBUILD to no longer extract the GCM binaries, but manually extract them to an architecture-specific directory - this way we don't cross-contaminate.