Fix issue where two required stars are added for nested required field #746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndbroadbent
added a commit
to DocSpring/alpaca
that referenced
this pull request
Jan 22, 2026
Added comprehensive documentation of: - Open PRs gitana#746 and gitana#747 from 2020 that contain DocSpring fixes - Related issues gitana#570, gitana#745, gitana#748, gitana#749 that affect the codebase - Clarified which commits are DocSpring-specific vs general improvements - Linked issues to specific DocSpring commits where applicable This provides complete context for future maintenance and upstream updates. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was happening for required fields inside an object. Changing the
findtochildrenprevents jQuery from searching recursively and adding too many stars.Before
After
(Screenshots are a bit different in my fork.)