0 script diffs are logged as debug instead of info #128
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request refactors logging behavior for script comparison changes to reduce noise in log output. When generating database schema changes, entities that produce 0 diffs are now logged at Debug level instead of Information level, making the Information-level logs focus only on meaningful changes.
Key Changes:
- Introduced
LogChangeResulthelper method to centralize logging logic - Dynamic log level selection: Information for changes with scripts, Debug for no-change scenarios
- Added proper singular/plural handling for "script" vs "scripts" in log messages
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| var level = scriptCount > 0 ? LogLevel.Information : LogLevel.Debug; | ||
| var scriptsLabel = scriptCount == 1 ? "script" : "scripts"; | ||
| var message = alreadyExists | ||
| ? $"{entityKey} already exists, created {scriptCount} {scriptsLabel} to apply the diffs" |
There was a problem hiding this comment.
The two log messages have inconsistent punctuation. The "already exists" message (line 349) doesn't end with a period, while the "doesn't exist" message (line 350) ends with a period. For consistency, both messages should either have or not have a trailing period.
| ? $"{entityKey} already exists, created {scriptCount} {scriptsLabel} to apply the diffs" | |
| ? $"{entityKey} already exists, created {scriptCount} {scriptsLabel} to apply the diffs." |
This pull request refactors how logging is handled when generating script compare changes in the
DatabaseChanges.csfile.The main change is that scripts that produce 0 diffs are logged only in Debug instead of Information level; this removes a lot of noise from the logging output for entities that did not change.