migrate from coffeescript to plain javascript #1316
+204
−157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR migrates the frontend JavaScript code from CoffeeScript to plain JavaScript (ES6+), modernizing the codebase and simplifying the build pipeline. The migration maintains the same functionality while adopting modern JavaScript syntax including ES6 classes, arrow functions, and template literals.
Key Changes:
- Converted CoffeeScript classes to ES6 JavaScript classes with proper constructor initialization
- Replaced CoffeeScript's fat arrow functions with JavaScript arrow functions for proper
thiscontext binding - Removed jekyll-coffeescript plugin dependency from the build configuration
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| assets/js/app.js | New JavaScript file containing the migrated Choosealicense and LicenseSuggestion classes with ES6 syntax |
| assets/js/app.coffee | Removed the original CoffeeScript source file |
| _config.yml | Removed app.coffee from exclude list and jekyll-coffeescript from plugins |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exactly what the title said. I want to clean up #1139 and perhaps other things and figure simplifying first will help.