Upgrade to MCP Go SDK v1.2.0-pre.1 and add Octicon icons to tools #1588
+104
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR upgrades the MCP Go SDK from v1.1.0 to v1.2.0-pre.1 with SEP-973 support. Changes: - Upgrade go-sdk to v1.2.0-pre.1 (adds icons, tool validation, elicitation) - Add Icon field to ToolsetMetadata with Octicon names - Add OcticonURL() and ToolsetIcon() helpers for icon generation - Add SetIcons() and applyIcons() to Toolset for auto icon assignment - Add WithIcons() on ServerTool for manual icon setting - Configure Octicon icons for all toolsets (repo, issue-opened, etc.) - Icons provided in 16x16 and 24x24 SVG from Primer Octicons CDN
t3xash0rnyt0ad777-commits
approved these changes
Dec 13, 2025
t3xash0rnyt0ad777-commits
suggested changes
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades the MCP Go SDK from v1.1.0 to v1.2.0-pre.1, which adds support for SEP-973 (icons and metadata). The new SDK includes:
Changes
SDK Upgrade
github.com/modelcontextprotocol/go-sdkto v1.2.0-pre.1Icon Support Implementation
Iconfield toToolsetMetadatastruct with Octicon namesOcticonURL()helper function to generate Octicon CDN URLsToolsetIcon()method onToolsetMetadatato createmcp.IconslicesSetIcons()method onToolsetfor setting default icons per toolsetapplyIcons()method to automatically apply toolset icons to tools when addedWithIcons()method onServerToolfor manual icon assignmentConfigured Icons
Each toolset now has an appropriate Octicon icon assigned:
Icons are sourced from GitHub's Primer Octicons and provided in both 16x16 and 24x24 sizes as SVG via the CDN URL format:
https://raw.githubusercontent.com/primer/octicons/main/icons/{name}-{size}.svgTesting
script/lintpassesscript/testpassesNotes
This is a draft PR to test compatibility with the pre-release SDK. The icons feature requires MCP clients that support the new icons specification (SEP-973).