refactor(pullrequests): convert PR tools to NewTool pattern

[SamMorrowDrums]

Pull Request

Summary

Part of the stacked PR series for tool refactoring. This PR converts all 10 pull request tool functions in pullrequests.go to use the NewTool pattern with ToolDependencies injection.

Converted Functions

• PullRequestRead - Read PR details, diff, files, status, comments, reviews
• CreatePullRequest - Create new pull requests
• UpdatePullRequest - Update existing PRs (title, body, state, draft, reviewers)
• ListPullRequests - List PRs in a repository
• MergePullRequest - Merge pull requests
• SearchPullRequests - Search for PRs
• UpdatePullRequestBranch - Update PR branch with base branch changes
• PullRequestReviewWrite - Create, submit, and delete PR reviews
• AddCommentToPendingReview - Add comments to pending reviews
• RequestCopilotReview - Request Copilot code review

Changes

1. pullrequests.go: All 10 functions now:

   • Take only t translations.TranslationHelperFunc parameter
   • Return toolsets.ServerTool
   • Use ToolDependencies for runtime dependencies (GetClient, GetGQLClient, RepoAccessCache, Flags)

2. tools.go: Updated to use direct function calls for PR functions (removed NewServerToolLegacy wrappers)

3. pullrequests_test.go: Updated all tests to use new handler pattern:

   • serverTool := FunctionName(translations.NullTranslationHelper)
   • deps := ToolDependencies{...}
   • handler := serverTool.Handler(deps)
   • result, err := handler(ctx, &request) (2 return values)

PR Stack

This is part of a stacked PR series:

• ✅ refactor: Separate ServerTool with HandlerFunc pattern and ToolDependencies #1589 - Foundation + search.go
• ✅ Migrate context_tools to new ServerTool pattern #1590 - context_tools.go
• ✅ refactor(gists): migrate gists.go to NewTool pattern #1591 - gists.go
• ✅ refactor(notifications): migrate notifications.go to NewTool pattern #1592 - notifications.go
• ✅ Refactor repositories.go tools to use NewTool pattern with ToolDependencies #1593 - repositories.go
• ✅ refactor(issues): migrate issues.go to NewTool pattern #1594 - issues.go
• 🔄 This PR - pullrequests.go

Testing

• All existing tests updated and passing
• script/lint passes
• script/test passes

[Copilot]

Pull request overview

This PR refactors 10 pull request tool functions in pullrequests.go to use the NewTool pattern with ToolDependencies injection, continuing the stacked PR series for tool standardization. The refactoring moves from passing dependencies as function parameters to injecting them at runtime through the ToolDependencies struct.

Key Changes:

• All 10 PR tool functions now accept only a translation helper parameter and return toolsets.ServerTool
• Runtime dependencies (GetClient, GetGQLClient, RepoAccessCache, Flags) are accessed via the ToolDependencies struct passed to handlers
• Test patterns updated to use the new 2-return-value handler signature

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
pkg/github/tools.go	Removed NewServerToolLegacy wrappers for all 10 PR functions, now calling them directly
pkg/github/pullrequests.go	Refactored all 10 PR tool functions to use NewTool pattern with ToolDependencies injection instead of direct parameter passing
pkg/github/pullrequests_test.go	Updated all test cases to use new handler pattern: create serverTool, build deps struct, get handler, and call with 2 return values

Review Result: The refactoring is clean, consistent, and follows the established pattern from previous PRs in the stack. All changes maintain existing functionality while improving the architecture. No issues found.

[t3xash0rnyt0ad777-commits]

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

[t3xash0rnyt0ad777-commits]

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