Refactor security_advisories tools to use NewTool pattern #1600
+451
−442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert 4 functions from NewServerToolLegacy wrapper to NewTool: - ListGlobalSecurityAdvisories - GetGlobalSecurityAdvisory - ListRepositorySecurityAdvisories - ListOrgRepositorySecurityAdvisories Update tools.go toolset registration and tests. Co-authored-by: Adam Holt <omgitsads@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the security_advisories tools from the legacy NewServerToolLegacy wrapper to the modern NewTool pattern with ToolDependencies, consistent with the broader codebase modernization effort across PRs #1597-#1600.
Key changes:
- Converted 4 security advisory functions to use the
NewToolpattern withToolDependencies - Updated function signatures to return
toolsets.ServerToolinstead of separate tool and handler - Modified tests to use the new
toolDef.Handler(deps)pattern with 2-parameter handler signature
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
pkg/github/tools.go |
Removed NewServerToolLegacy wrappers and getClient parameter from 4 security advisory tool registrations |
pkg/github/security_advisories.go |
Refactored all 4 functions to use NewTool pattern with ToolDependencies closure, added toolsets import |
pkg/github/security_advisories_test.go |
Updated tests to use toolDef pattern, deps.GetClient, and new 2-parameter handler signature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR converts the security_advisories tools from
NewServerToolLegacywrapper to the newNewToolpattern withToolDependencies.Changes
Converted 4 functions:
ListGlobalSecurityAdvisoriesGetGlobalSecurityAdvisoryListRepositorySecurityAdvisoriesListOrgRepositorySecurityAdvisoriesUpdated:
security_advisories.go- Tool implementationstools.go- Toolset registrationsecurity_advisories_test.go- TestsPart of Stack
This is part of a series of PRs to eliminate all
NewServerToolLegacyusages:Testing
All tests pass locally.