-
Notifications
You must be signed in to change notification settings - Fork 1
ETL-516: Update to pipeline v2 #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
…w-python-sdk into update-to-pipeline-v2
Test Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| schema_fields[f"{field['source_id']}_{field['field_name']}"].update( | ||
| {"column_name": field["column_name"], "column_type": field["column_type"]} | ||
| ) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't the migration script need to handle the case with dedup_key not in mapping ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script will first add all the fields in in the topic schemas with source_id, name and type. Then will add the column_name and column_type to the fields that are mapped to the ClickHouse table in the table_mapping.
So it will handle those cases. It will also add other fields that are not mapped but appear in the topic schema
No description provided.