Skip to content

Conversation

@PabloPardoGarcia
Copy link
Member

No description provided.

@PabloPardoGarcia PabloPardoGarcia changed the title Update to pipeline v2 ETL-516: Update to pipeline v2 Dec 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

Coverage

Test Coverage Report
FileStmtsMissCoverMissing
glassflow/etl
   __init__.py50100% 
   api_client.py64592%70–73, 123
   client.py39489%59–61, 141
   dlq.py41295%45, 70
   errors.py270100% 
   pipeline.py146795%334–337, 350, 406–407
   tracking.py260100% 
   utils.py11110%1, 3, 6, 8–11, 17–18, 22, 28
glassflow/etl/models
   __init__.py100100% 
   base.py10460%7–10
   config.py34876%37, 40–41, 43–45, 47–48
   data_types.py770100% 
   filter.py17852%12, 15–18, 20–22
   join.py51296%44, 80
   metadata.py40100% 
   pipeline.py89396%135, 145, 148
   schema.py260100% 
   sink.py61788%33, 39, 47, 49, 53, 55, 61
   source.py132794%47, 51, 68, 81, 124, 150, 166
TOTAL8706892% 

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

Coverage

Test Coverage Report
FileStmtsMissCoverMissing
etl
   __init__.py50100% 
   api_client.py64592%70–73, 123
   client.py39489%59–61, 141
   dlq.py41295%45, 70
   errors.py270100% 
   pipeline.py146795%334–337, 350, 406–407
   tracking.py260100% 
   utils.py11110%1, 3, 6, 8–11, 17–18, 22, 28
etl/models
   __init__.py100100% 
   base.py10460%7–10
   config.py34876%37, 40–41, 43–45, 47–48
   data_types.py770100% 
   filter.py17852%12, 15–18, 20–22
   join.py51296%44, 80
   metadata.py40100% 
   pipeline.py89396%135, 145, 148
   schema.py260100% 
   sink.py61788%33, 39, 47, 49, 53, 55, 61
   source.py132794%47, 51, 68, 81, 124, 150, 166
TOTAL8706892% 

schema_fields[f"{field['source_id']}_{field['field_name']}"].update(
{"column_name": field["column_name"], "column_type": field["column_type"]}
)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't the migration script need to handle the case with dedup_key not in mapping ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script will first add all the fields in in the topic schemas with source_id, name and type. Then will add the column_name and column_type to the fields that are mapped to the ClickHouse table in the table_mapping.

So it will handle those cases. It will also add other fields that are not mapped but appear in the topic schema

@ashish-bagri ashish-bagri self-requested a review December 4, 2025 15:04
@PabloPardoGarcia PabloPardoGarcia merged commit cc7cf6c into main Dec 4, 2025
@PabloPardoGarcia PabloPardoGarcia deleted the update-to-pipeline-v2 branch December 4, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants