Add error messages when somethings goes wrong #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else { | ||
| this.setAlert(true, `The bot was unable to sell. ${error.toString()}.`, 'danger'); | ||
| this.setSellEnabled(false); | ||
| } |
Collaborator
There was a problem hiding this comment.
Add return statement to if & remove else block
| checkAPIKeys = () => { | ||
| const { key, secret } = this.props.opts.binance; | ||
| if (!key || !secret) { | ||
| this.setAlert(true, 'API key/secret not defined. Take a look at the readme on how to add these and restart the server.', 'danger'); |
Collaborator
There was a problem hiding this comment.
this.setAlert(
true,
'API key/secret not defined. Take a look at the readme on how to add these and restart the server.',
'danger'
);| } | ||
| }; | ||
|
|
||
| setAlert = (open, message, color) => { |
Collaborator
There was a problem hiding this comment.
This micro API is vague and unnecessary. You're better of without it, really
Owner
Author
There was a problem hiding this comment.
When removing this method, there will be much duplicated code to implement the same functionality.
Collaborator
There was a problem hiding this comment.
No there won't be since you're essentially just setting the state.
You could replace a call to setAlert like this:
setAlert(true, 'Foobar', 'warning');with this:
this.setState({
alert: {
open: true,
message: 'Foobar',
color: 'warning',
},
});This is longer but much, much much more clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.