Improve systemd units

[seblu]

No description provided.

[kaihendry]

The current https://github.com/gnosek/fcgiwrap/blob/master/systemd/fcgiwrap.service#L6 does not work on a Archlinux system. I spent HOURS over nginx 403 Forbidden errors. Eventually I came up with: http://ix.io/7kP

And to my surprise I found a service file in the Arch packaging that isn't utilised: https://projects.archlinux.org/svntogit/community.git/tree/trunk/fcgiwrap.service?h=packages/fcgiwrap

I don't know who to blame, though I guess I will report a bug on Archlinux now too.

[falconindy]

does not work on a Archlinux system.

I disagree. http://code.falconindy.com is using the upstream fcgiwrap.service and fcgiwrap.socket without any problems. You'll need to be a more specific than "does not work."

Being the original author of these units and someone who's reliant on them, I strongly oppose simply deleting the old units as it will break existing setups.

[kaihendry]

I get "502 Bad Gateway" with your default http://ix.io/7kQ

However if I use my own spawn-fcgi invocation, it works: http://ix.io/7kP

My nginx.conf is http://sprunge.us/hEZT

Any ideas how to debug this?

[kaihendry]

Ok nevermind @falconindy, you service file does seem to work after after all.
http://ix.io/7x8

I'm using it upon http://cam.hackerspace.sg/

Thanks for your time,

[seblu]

Any change to have this merged?

Old file can easily be moved to new one by a systemctl enable fcgiwrap@http.socket.

If upstream still want maintain arch specific files, I can push a new version which don't touch old files.

[seblu]

Any progress on this?

[kaihendry]

@seblu I'm not sure what the benefit is for folks to use non-http user convention? It's bad enough that it's different from Debian's www-data and dealing with all the annoying perms.

[Lekensteyn]

Shouldn't this be $(SED) when using AC_PROG_SED?

[Lekensteyn]

@kaihendry Privilege separation, defence in depth? The web user has no rights to read "private" git dirs of cgit for example?

[gnosek]

Looks good to me, please apply @Lekensteyn 's suggestions and I'll (finally!) merge it.

[seblu]

Suggestions applied. Should be ok.

[Lekensteyn]

LGTM for user-specific fcgiwraps (personally I use -p to further restrict executable programs, introduced by 3a94c23)

[petercolberg]

@seblu to improve upon this pull request, could you apply the following changes?

Group socket files in a subdirectory, and make them accessible by the httpd user/group only:

# fcgiwrap@.socket
[Socket]
ListenStream=/run/fcgiwrap/%I.socket
SocketUser=@socketuser@
SocketGroup=@socketgroup@
SocketMode=0660

Create the shared runtime directory at boot using tmpfiles.d:

# @tmpfilesdir@/fcgiwrap.conf
d /run/fcgiwrap 0550 @socketuser@ @socketgroup@ - -

Add configure options to set the httpd user/group:

# configure.ac
AC_ARG_WITH([socket-user],
        AC_HELP_STRING( [--with-socket-user=USER], [User for socket files (defaults to httpd)]),
        [socketuser=$withval], [socketuser=httpd])
AC_SUBST(socketuser)

AC_ARG_WITH([socket-group],
        AC_HELP_STRING( [--with-socket-group=GROUP], [Group for socket files (defaults to httpd)]),
        [socketgroup=$withval], [socketgroup=httpd])
AC_SUBST(socketgroup)