Skip to content

Check user visibility when redirecting to a renamed user #36148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
silverwind merged 2 commits into from
Dec 14, 2025
Merged

Check user visibility when redirecting to a renamed user #36148

silverwind merged 2 commits into from
Dec 14, 2025
+92 −8

Conversation

@lunny
Copy link
Member

@lunny lunny commented Dec 13, 2025

Fix #34169

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 13, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Dec 13, 2025
@delvh delvh changed the title Fix bug when visit a renamed user Check user visibility when redirecting to a renamed user Dec 13, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 13, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 13, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 13, 2025
@silverwind silverwind merged commit 1f5237e into go-gitea:main Dec 14, 2025
23 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Dec 14, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 14, 2025
@lunny lunny deleted the lunny/fix_user_redirect_visibility branch December 14, 2025 02:17
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 14, 2025
@lunny @GiteaBot
Check user visibility when redirecting to a renamed user (go-gitea#36148
c3f7b87 
)

Fix go-gitea#34169
@GiteaBot GiteaBot mentioned this pull request Dec 14, 2025
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Dec 14, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 15, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
df53846 
* giteaofficial/main:
  Remove undocumented support of signing key in the repository git configuration file (go-gitea#36143)
  Enable gocheckcompilerdirectives linter (go-gitea#36156)
  Fix code highlighting on blame page (go-gitea#36157)
  Check user visibility when redirecting to a renamed user (go-gitea#36148)
  Fix bug when viewing the commit diff page with non-ANSI files (go-gitea#36149)
  Refactor `FileTreeItem` type (go-gitea#36137)
  Fix various bugs (go-gitea#36139)
  Fix issue close timeline icon (go-gitea#36138)
  Add permissions to`files-changed` jobs (go-gitea#36142)
  Add explicit permissions to all actions workflows (go-gitea#36140)
  Bump `actions/checkout` to v6 (go-gitea#36136)
  Hide RSS icon when viewing a file not under a branch (go-gitea#36135)
  Fix SVG size calulation, only use `style` attribute (go-gitea#36133)
  Add sorting/filtering to admin user search API endpoint (go-gitea#36112)
lafriks pushed a commit that referenced this pull request Dec 15, 2025
@GiteaBot @lunny
Check user visibility when redirecting to a renamed user (#36148) (#3…
d448ab9 
…6159)

Backport #36148 by @lunny

Fix #34169

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delvh delvh delvh approved these changes

+1 more reviewer

@Zettat123 Zettat123 Zettat123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created backport/v1.25 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code type/bug

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

Previously edited private user URLs will redirect instead of 404'ing

5 participants

@lunny @Zettat123 @delvh @silverwind @GiteaBot