-
Notifications
You must be signed in to change notification settings - Fork 31
feat(events)!: support merge queue for GitHub SCM #1343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (58.27%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1343 +/- ##
==========================================
- Coverage 58.36% 58.27% -0.10%
==========================================
Files 645 644 -1
Lines 24864 25004 +140
==========================================
+ Hits 14511 14570 +59
- Misses 9681 9755 +74
- Partials 672 679 +7
🚀 New features to boost your workflow:
|
wass3r
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first pass - see below
|
|
||
| if len(input.GetMergeQueueEvents()) > 0 { | ||
| for _, event := range input.GetMergeQueueEvents() { | ||
| if !slices.Contains([]string{constants.EventPush, constants.EventPull, constants.EventComment}, event) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we call out valid merge queue events somewhere in docs?
ref: go-vela/community#1061
Breaking Changes
merge_queue_events, which will be a list of events that themerge_groupevent build will report to. This is necessary to preserve normal required status checks while also allowing for a merge queue. Vela is event-based in its status checks, not job-name-based. So required checks from apull_requestbuild will need to be targeted formerge_groupevents.Opt In
Ultimately, this is opt-in functionality. If users do not supply any override events, then Vela will behave the exact same.
Pipeline Changes
Auto Cancel
Determining stale builds for a merge group is different than normal builds. Stale builds are defined as builds that are
pendingorrunningthat are part of the merge group and also include a build that failed. There's a more detailed description of this in the reference link.