Skip to content

Conversation

@wass3r
Copy link
Collaborator

@wass3r wass3r commented Oct 24, 2025

fixes go-vela/community#487

we are very generous with what we allow for secret/schedule names. unfortunately it's possible to create resources you can't retrieve if they contain certain characters. it's also possible to create resources with certain character in its name that are retrievable, but the UI wasn't able to handle that correctly. this fixes that. there should be a follow-up fix on the API side to disallow creating resources with certain characters to avoid the scenario of un-retrievable secrets, in particular resources that are queried by name in the URI (which should be its own discussion, probably) 😞. we still need to support existing resources that were created with "creative" names to allow management (hopefully a delete?).

in summary, this PR:

  • prevents user from creating resources with un-retrievable names if they contain certain characters
  • fixes an issue where characters weren't encoded/decoded correctly to allow management of resources using certain characters (#, ', ?, etc) in their name

@wass3r wass3r requested a review from a team as a code owner October 24, 2025 18:48
KellyMerrick
KellyMerrick previously approved these changes Dec 11, 2025
@KellyMerrick KellyMerrick dismissed their stale review December 11, 2025 14:55

failed after merge to main

@wass3r
Copy link
Collaborator Author

wass3r commented Dec 13, 2025

@KellyMerrick looks like it was a temporary issue. i reran the failed workflow and it's good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

secrets with a name that starts with #/? are unable to be deleted or updated via UI/CLI

4 participants