fix(routing): special chars support #893
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes go-vela/community#487
we are very generous with what we allow for secret/schedule names. unfortunately it's possible to create resources you can't retrieve if they contain certain characters. it's also possible to create resources with certain character in its name that are retrievable, but the UI wasn't able to handle that correctly. this fixes that. there should be a follow-up fix on the API side to disallow creating resources with certain characters to avoid the scenario of un-retrievable secrets, in particular resources that are queried by name in the URI (which should be its own discussion, probably) 😞. we still need to support existing resources that were created with "creative" names to allow management (hopefully a delete?).
in summary, this PR:
#,',?, etc) in their name