enhance(theme): allow switching between light/dark/system #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this removes the setting link in the header which allowed for switching between dark/light mode and puts the theme setting into the user settings section available from the drop down in the top left. there, users will be able to choose from light, dark, and system. system being the new addition that will honor the system preferences. moving it to settings will also set up better for future additions to allow theme customization by users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: go-vela/community#1033
this removes the setting link in the header which allowed for switching between dark/light mode and puts the theme setting into the user settings section available from the drop down in the top left. there, users will be able to choose from light, dark, and system. system being the new addition that will honor the system preferences. moving it to settings will also set up better for future additions to allow theme customization by users.
one side effect is that the theme selection is not available immediately before logging in, but will persist once a theme is chosen regardless of being logged in or not.