fix: Windows stack overflow on Vulkan API calls #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace custom callWin64 assembly with syscall.SyscallN - The NOSPLIT,2 directive prevented Go runtime stack growth - Now uses Go runtime's asmstdcall mechanism (like purego) - Fixes Exception 0xc00000fd (STACK_OVERFLOW) on Windows Changed: - internal/arch/amd64/call_windows.go: Use syscall.CallWin64 - internal/syscall/syscall_windows_amd64.go: New SyscallN wrapper Removed: - internal/arch/amd64/call_windows.s: Source of the bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
callWin64assembly withsyscall.SyscallNasmstdcallmechanism (matches purego approach)Problem
The custom Windows FFI assembly used
NOSPLIT, $32which prevents Go runtime stack growth. When C functions (especially Vulkan APIs) require more stack space, this causedSTACK_OVERFLOW(Exception 0xc00000fd).Solution
Replace custom assembly with Go's
syscall.SyscallNwhich internally usesruntime.cgocall+asmstdcall. This is the same proven approach used by purego.Changes
internal/syscall/syscall_windows_amd64.go- New SyscallN wrapperinternal/arch/amd64/call_windows.go- Updated to use new syscallinternal/arch/amd64/call_windows.s- Removed (source of bug)Test Plan
Related
Bug report: gogpu/wgpu issues - Windows stack overflow on Vulkan calls