feat(core): Core-HAL Bridge implementation for v0.9.0 #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the foundation for connecting wgpu/core validation layer to wgpu/hal hardware abstraction layer. This enables core functions to create real GPU resources instead of placeholders. CORE-001: Snatchable[T] pattern - Generic wrapper for safe deferred destruction of HAL resources - SnatchLock/SnatchGuard for device-global coordination - Thread-safe with RWMutex semantics CORE-002: Device wraps HAL - Device struct embeds Snatchable[hal.Device] - NewDevice() constructor for HAL-integrated devices - Destroy() with proper HAL cleanup - Backward compatibility with ID-based API CORE-003: Buffer wraps HAL - Buffer struct embeds Snatchable[hal.Buffer] - BufferInitTracker for initialization tracking - BufferMapState for mapping state management - TrackingData stub for future state tracking CORE-004: CreateBuffer validation flow - Device.CreateBuffer() with full WebGPU validation - Size, usage, and mapping validation - CreateBufferError with detailed error context - types.BufferUsage.Contains() and ContainsUnknownBits() Tests: 50+ new tests with 0 linter issues
Add HAL-integrated command encoder with proper state management: - CoreCommandEncoder with Recording/Locked/Finished/Error/Consumed states - CoreRenderPassEncoder and CoreComputePassEncoder for pass recording - CoreCommandBuffer for finished command buffers - CommandBufferMutable for resource tracking during encoding - Device.CreateCommandEncoder() method - CreateCommandEncoderError and EncoderStateError types Comprehensive test coverage with 84 tests passing.
Add dense index allocation for efficient resource state tracking: - TrackerIndex type with IsValid() helper - TrackerIndexAllocator with LIFO reuse for cache locality - SharedTrackerIndexAllocator for thread-safe sharing - TrackerIndexAllocators for all resource types - TrackingData for embedding in resources - Comprehensive tests including concurrent access
Add buffer usage tracking for automatic barrier generation: - BufferUses flags for granular usage states - BufferTracker for device-level state tracking - BufferUsageScope for per-command-buffer tracking - StateTransition and PendingTransition for barrier insertion - Merge() generates transitions when scopes are combined - IntoHAL() converts transitions to HAL BufferBarriers - ResourceMetadata for ownership tracking - Comprehensive tests with benchmarks
Convert 27 TODO comments in core/ package to proper documentation: - Mark legacy ID-based API functions as Deprecated - Add Note: comments explaining HAL integration architecture - Document that ID-based API is for validation, HAL-based for GPU ops Files updated: adapter.go, command.go, device.go, instance.go, pipeline.go, queue.go
HAL backends cleanup (58 TODOs removed): - Vulkan: Document feature/limits mapping gaps with version targets - DX12: Document advanced feature requirements - GLES: Document GL version requirements and limitations Added Known Limitations section to CHANGELOG.md. Created GitHub issues #32-#36 for future implementation. Files: 17 changed across hal/vulkan, hal/dx12, hal/gles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the Core-HAL Bridge - the foundational layer connecting wgpu/core (validation/state tracking) with wgpu/hal (GPU backends).
Features (CORE-001 → CORE-007)
Code Quality
Metrics
Test Plan