fix(vulkan): device destruction, features and limits mapping #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#34) - Fix vkDestroyDevice memory leak via goffi CallFunction - Implement featuresFromPhysicalDevice() mapping 9 Vulkan features - Implement limitsFromProps() mapping 25+ hardware limits - Add comprehensive tests for features mapping - Update documentation for v0.9.1 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Vulkan backend fixes for v0.9.1:
featuresFromPhysicalDevice()mapping 9 Vulkan features to WebGPUlimitsFromProps()mapping 25+ hardware limitsChanges
hal/vulkan/adapter.govkDestroyDevicevia goffiCallFunctionhal/vulkan/api.gofeaturesFromPhysicalDevice(), updatelimitsFromProps()hal/vulkan/api_test.goCHANGELOG.mdROADMAP.mdscripts/pre-release-check.shCloses
Closes #32 — vkDestroyDevice memory leak
Closes #33 — Vulkan features not mapped to WebGPU features
Closes #34 — Vulkan limits not mapped to WebGPU limits
Test Plan
go test ./hal/vulkan/...— All passgolangci-lint run— 0 issuesscripts/pre-release-check.sh— All checks pass