Skip to content

Conversation

@polesye
Copy link
Contributor

@polesye polesye commented Feb 8, 2025

This PR adds .editorconfig file with code style the rules that different editors can apply when format the code.

https://learn.microsoft.com/en-us/visualstudio/ide/cpp-editorconfig-properties?view=vs-2022

@polesye
Copy link
Contributor Author

polesye commented Feb 8, 2025

@dehydr8 could you review it?

@dehydr8
Copy link
Member

dehydr8 commented Feb 15, 2025

Hi @polesye, the build/test is failing because of an outdated version of actions/upload-artifact. I've fixed it in master, if you pull the changes from master into your branch, the tests should work.

I would've done it but your PR doesn't allow modifications from maintainers.

@dehydr8
Copy link
Member

dehydr8 commented Feb 15, 2025

The build/test is failing, which is unrelated to your change. I'll take a deeper look. It's likely related to ubuntu-latest which is missing a package.

@dehydr8
Copy link
Member

dehydr8 commented Feb 15, 2025

Hi @polesye, the failing tests were due to the ubuntu-latest being used. The latest tag now points to 24.04 by GitHub. I have pinned it to ubuntu-22.04 in our CI/CD. If you merge changes from master, the tests should work.

@dehydr8 dehydr8 merged commit 088943d into good-tools:master Feb 15, 2025
1 check passed
@github-actions
Copy link

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants