Update to Wireshark 4.4.5 #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is some "smart" logic around what the data directory path should be, but fails to return the correct directory. This change patches the get_datafile_dir() function to return DATA_DIR. This fixes the colorfilters file not loading correctly.
…+ io_graph resets
dehydr8
force-pushed
the
wireshark-update-4.4.5-merge-master
branch
from
cd5fd86 to
639b8e5
Compare
Member
Author
|
@dipeshwalia can you please try reproducing the issue in this one? |
Contributor
tcp_pref_issue.pcap.zip, ill try with this branch as well. const result = wg.lib.setPref("diameter", "tcp.port", '3871')the above pref works with the master branch and not with 4.4.5 branch. thank you! |
Contributor
|
@dehydr8, it seems like we are good with this PR. thank you, |
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to do the following:
masterintowireshark-update-4.4.5(that branch has a stable update to 4.4.5), fixing conflicts*.cppfiles usingclang-format#19