Refactor imas loader #1861
Open
Refactor imas loader #1861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MateoBell
added
the
ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
imas_tools.input.loadertoutilsand move private function_get_time_and_radial_arraysout ofimas_tools.input.core_profiles.pyinto this new module.Added docstring and unit test for the function testing for
core_profilesandcore_sourcesIDSs.Added a dummy core_sources IDS generated by hand with 1 time slice containing a standard rhon array and a basic gaussian
electrons.energy.Drive-by: Prepare for PR implementing mapping of sources from a
core_sourcesIDS which will use this function as well.