Resolves Relative Effects incorrect (wrong sign) when post-period mean is negative #31 #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi there, thanks for flagging. This will be resolved in CausalImpact 1.3, which is about to get pushed to GitHub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request resolves the Relative Effects incorrect (wrong sign) when post-period mean is negative #31 that was posted here and confirmed by myself and others. I have tested this fix and it resolves the issue without creating new issues. True negative impacts are still recorded as such, but false-negatives are avoided. Please confirm if this is a helpful pull request or not. Thank you.