Skip to content

Update nrf52840_dongle.md #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
icicle1133 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update nrf52840_dongle.md #754

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion docs/boards/nrf52840_dongle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,13 @@ customize it.
You need `nrfutil` version 6. The [install manual](../install.md) has
setup instructions.

To flash the firmware, run:
It is highly recommended you use --erase_storage first, especially if you have installed any other software onto your dongle.
Copy link

@gemini-code-assist gemini-code-assist bot Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The phrasing "It is highly recommended" might be too weak. Based on your PR description and the general install.md guide, erasing storage seems to be a required step for new boards or boards that have been used for other purposes. To avoid user confusion and flashing issues, it would be better to make this instruction more direct.

Suggested change
It is highly recommended you use --erase_storage first, especially if you have installed any other software onto your dongle.
To prevent potential issues, you must first erase the dongle's storage. This is especially important for new boards or if other software has been installed on it.


```shell
./deploy.py --board=nrf52840_dongle_dfu --erase_storage
Copy link

@gemini-code-assist gemini-code-assist bot Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The command to flash the erase_storage application is missing the --programmer=nordicdfu argument. Without it, the deploy.py script defaults to using jlink as the programmer. This is incorrect for the DFU flashing method described in this document and will cause an error for users who don't have a J-Link debugger.

Suggested change
./deploy.py --board=nrf52840_dongle_dfu --erase_storage
./deploy.py --board=nrf52840_dongle_dfu --erase_storage --programmer=nordicdfu

```

Then to flash the firmware:
```shell
./deploy.py --board=nrf52840_dongle_dfu --opensk --programmer=nordicdfu
```
Expand Down
Loading