-
Notifications
You must be signed in to change notification settings - Fork 2.1k
chore: Reformatted the podcast-transcript-agent sample by ensuring black, isort, and flake8 pass #763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: Reformatted the podcast-transcript-agent sample by ensuring black, isort, and flake8 pass #763
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,6 +12,4 @@ | |
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| from .agent import podcast_transcript_writer_agent | ||
|
|
||
|
|
||
| from .agent import podcast_transcript_writer_agent # noqa: F401 | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above. |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,13 +12,14 @@ | |
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import json | ||
| from pathlib import Path | ||
|
|
||
| import dotenv | ||
| import pytest | ||
| from google.adk.runners import InMemoryRunner | ||
| from podcast_transcript_agent.agent import podcast_transcript_agent | ||
| from pathlib import Path | ||
| from google.genai import types | ||
| import dotenv | ||
| import json | ||
| from podcast_transcript_agent.agent import podcast_transcript_agent | ||
|
|
||
|
|
||
| @pytest.fixture(scope="session", autouse=True) | ||
|
|
@@ -46,9 +47,7 @@ async def test_run_with_txt(): | |
| ) | ||
| ), | ||
| types.Part( | ||
| inline_data=types.Blob( | ||
| mime_type="text/plain", data=file_content | ||
| ) | ||
| inline_data=types.Blob(mime_type="text/plain", data=file_content) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. length
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| ), | ||
| ] | ||
| ) | ||
|
|
@@ -75,6 +74,4 @@ async def test_run_with_txt(): | |
| if data["metadata"]["duration_seconds"] > 0: | ||
| found_valid_transcript = True | ||
|
|
||
| assert ( | ||
| found_valid_transcript | ||
| ), "No final event found with valid transcript metadata" | ||
| assert found_valid_transcript, "No final event found with valid transcript metadata" | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. length
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This line is exactly 88 chars. When I ran |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this import be moved to where the import is actually used? (to avoid having to use
noqa)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good comment for the sample owner. I don't want to make such changes though, since I am just applying formatters to the sample in this PR.