Refactor match output compiling to accept user-defined logic. #1246
+55
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catalinadurbala
force-pushed
the
structured-explanations-v2
branch
from
52a4c13 to
8e7bebc
Compare
Contributor
Author
|
I've added a layer of abstraction to the input parameters to hide as many of the internals as possible - unfortunately I realised that the rule Env is still needed, as we're planning to use the optimizer with it. Do let me know if that's alright with you. |
Collaborator
|
/gcbrun |
TristonianJones
previously approved these changes
Jan 9, 2026
catalinadurbala
force-pushed
the
structured-explanations-v2
branch
2 times, most recently
from
c8e2cde to
eb5cf30
Compare
Collaborator
|
/gcbrun |
catalinadurbala
force-pushed
the
structured-explanations-v2
branch
from
eb5cf30 to
2ec29b3
Compare
Collaborator
|
/gcbrun |
seirl
approved these changes
Jan 13, 2026
Collaborator
seirl
left a comment
seirl
left a comment
There was a problem hiding this comment.
Approving this since it's almost identical to the changes @TristonianJones approved earlier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As follow-up to #1244, I've narrowed down the changes to the minimum surface that we need to interact with in order to compile our explanations. Please let me know what you think!