Add clarification on scoping rules. #506
Merged
+271
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add clarification on comprehension scoping and conformance tests.
doc/langdef.md
Outdated
| comprehension. If there is a match, that interpretation is chosen. If not, | ||
| the name is resolved against parent scopes until a match is found or the global | ||
| scope is searched. For example, in `[1].exists(x, x == 1)`, the interpretation | ||
| that `x` is the iterator variable is chosen over any alternative. |
Collaborator
There was a problem hiding this comment.
Maybe rephrase as:
For example, in `[1].exists(x, x == 1)` the iteration variable `x` is a local variable which shadows any identifier with the same simple name in ancestor scopes.
I'm still not sure if that's quite right, but I think we should phrase this as "scoping" and "shadowing".
jnthntatum
force-pushed
the
resolution_clarfication
branch
from
4ede9ef to
1989870
Compare
l46kok
reviewed
Jan 7, 2026
jnthntatum
force-pushed
the
resolution_clarfication
branch
from
1989870 to
b8b1290
Compare
jnthntatum
commented
Jan 7, 2026
jcking
reviewed
Jan 7, 2026
jnthntatum
force-pushed
the
resolution_clarfication
branch
from
f0348fe to
6006184
Compare
jnthntatum
force-pushed
the
resolution_clarfication
branch
from
6006184 to
6bb648c
Compare
l46kok
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add clarification on comprehension scoping and conformance tests.
I think this is implied but not spelled out anywhere. The Go / Java / C++ checker implementations don't handle this well when there's a collision with a qualified name in the root scope.