Export USRs as a unique_name field for C++ declarations.
#268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives us a good key we can aggregate on, including for overloaded functions. Just the name is not sufficient, as e.g. functions can have the same name as types, and even the same name as other functions (other overloads). Also, as a bonus, the USR is also used by Kythe AIUI, so if we wanted to join with Kythe data we could join on the truncated SHA1 hash of the unique_name. PiperOrigin-RevId: 855469014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export USRs as a
unique_namefield for C++ declarations.This gives us a good key we can aggregate on, including for overloaded functions. Just the name is not sufficient, as e.g. functions can have the same name as types, and even the same name as other functions (other overloads).
Also, as a bonus, the USR is also used by Kythe AIUI, so if we wanted to join with Kythe data we could join on the truncated SHA1 hash of the unique_name.