Remove default value from rs_std::char_::value_. #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default value makes this class non-C compatible and triggers "-Wreturn-type-C-linkage" (see corresponding bug). We need a solution to make our class C linkable since it appears in extern "C" decls. This solution may not be the best, since it violates our `char_` invariants around being a valid unicode codepoint. I could not find a way to override C abi compatibility. PiperOrigin-RevId: 856738276
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove default value from rs_std::char_::value_.
The default value makes this class non-C compatible and triggers
"-Wreturn-type-C-linkage" (see corresponding bug). We need a solution to
make our class C linkable since it appears in extern "C" decls. This
solution may not be the best, since it violates our
char_invariantsaround being a valid unicode codepoint. I could not find a way to
override C abi compatibility.