Suppress "-Wreturn-type-c-linkage" in generated bindings. #330
+163
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_860257643
branch
2 times, most recently
from
7f8c7ed to
d27d9c4
Compare
`char_` is technically not C linkage compatible because it has a nontrivial constructor, but in practice it is compatible (four our use of it in bindings) and we would prefer to suppress the warning rather than give it a trivial constructor that makes it less safe to use. PiperOrigin-RevId: 860257643
copybara-service
bot
force-pushed
the
test_860257643
branch
from
d27d9c4 to
c58f967
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress "-Wreturn-type-c-linkage" in generated bindings.
char_is technically not C linkage compatible because it has anontrivial constructor, but in practice it is compatible (four our use
of it in bindings) and we would prefer to suppress the warning rather
than give it a trivial constructor that makes it less safe to use.