Enable shadow warning for :bindings_support.
#331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_860270448
branch
2 times, most recently
from
f33b957 to
c6ec575
Compare
Chrome turns on `-Wshadow`, so we want our support libs to be compliant so we don't cause error in their build. PiperOrigin-RevId: 860285239
copybara-service
bot
force-pushed
the
test_860270448
branch
from
c6ec575 to
8394b21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable shadow warning for
:bindings_support.Chrome turns on
-Wshadow, so we want our support libs to be compliantso we don't cause error in their build.