Move db::type_visibility to a #[provided] function.
#332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_860280053
branch
from
3a5437f to
2fc3f4a
Compare
copybara-service
bot
force-pushed
the
test_860280053
branch
from
2fc3f4a to
9536ebf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
db::type_visibilityto a#[provided]function.This is possible now that provided functions were changed from being defined on the trait to being defined on the
impl Trait for Database-- the specific type is known, making dyn coercion work again.What a royal pain!
This, in turn, signals that we can use
#[provided]functions to do some pretty nifty things without (yet?) moving off of the&dyn Traittype.