-
Notifications
You must be signed in to change notification settings - Fork 148
Add binary releases via github actions #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Thanks for your contribution! Your PR has been imported to Gerrit. |
|
@kainino0x (Responding to https://dawn-review.googlesource.com/c/dawn/+/282075/comment/df0a6726_a15314d5/)
Yes, if I understood correctly, the release job will always run separately. I won't reuse the previous job on its own. However, the same effect can be achieved by implementing caching. We already have caching enabled for Linux but it doesn't appear to work, I think we need to use a different caching library that works and supports all platforms.
Personally I think separating them is probably better, especially if we improve caching, but I haven't looked into this. |
Bug https://crbug.com/430624000. See also https://issues.chromium.org/issues/409590665#comment6. Here's an example of how the release would look: https://github.com/jacksonrl/dawn/releases/tag/v20251223.163459-jacksonrl.dawn.main The only difference is the name wouldn't have my name in it, which I think is autogenerated due to being a fork, and it would contain the macos/ios builds as well, which I disabled in my local version when testing due to low balance for macos runners (diff: jacksonrl/dawn@7d88c22...e53c2d0) There are some ways we could improve the release outputs, but I wanted to make as minimal changes as possible to prevent any breakage as I cannot test all these platforms. Therefore this just uploads the output from the existing CI, which is mentioned in 409590665. These are nightly releases so nobody is expecting them to be stable, we can always improve this later Motivation: Many people end up needing graphics at some point. Having prebuilt binaries allows people to choose WebGPU more readily, which strengthens the WebGPU ecosystem (eg. more libraries made with wglsl) and also allows people to potentially port their code to web at a later point. This is an imported pull request from #55 GITHUB_PR_HEAD_SHA=a4d1c88a5614c1362cd6ee63f87d6352f3e6d9d3 ORIGINAL_AUTHOR=jacksonrl <203005141+jacksonrl@users.noreply.github.com> Bug: 430624000 GitOrigin-RevId: 2508282 Change-Id: I226a2a5c2b08c7bb881e7910b5c42ff4ca52ed3e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/282075 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
|
🚀 PR was merged in e3231b9! |
|
Oops just saw your comment here. Thank you for the suggestion, better caching sounds nice. I have filed https://crbug.com/473585665 BTW, let me know if you have any input on the proposed change in https://dawn-review.googlesource.com/c/dawn/+/283135! |
Fixes https://issues.chromium.org/issues/409590665. See also https://issues.chromium.org/issues/409590665#comment6.
Here's an example of how the release would look: https://github.com/jacksonrl/dawn/releases/tag/v20251223.163459-jacksonrl.dawn.main The only difference is the name wouldn't have my name in it, which I think is autogenerated due to being a fork, and it would contain the macos/ios builds as well, which I disabled in my local version when testing due to low balance for macos runners (diff: jacksonrl/dawn@7d88c22...e53c2d0)
There are some ways we could improve the release outputs, but I wanted to make as minimal changes as possible to prevent any breakage as I cannot test all these platforms. Therefore this just uploads the output from the existing CI, which is mentioned in 409590665. These are nightly releases so nobody is expecting them to be stable, we can always improve this later
This also fixes the emdawnwebgpu release which was broken by 0979968 by removing
wgpuTextureGetTextureBindingViewDimensionfrom the emdawnwebgpu header. I'm not too familiar with the codebase so someone should please check that that is valid.Motivation: Many people end up needing graphics at some point. Having prebuilt binaries allows people to choose WebGPU more readily, which strengthens the WebGPU ecosystem (eg. more libraries made with wglsl) and also allows people to potentially port their code to web at a later point.
cc @wcandillon